Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to google fonts version 2 #21478

Closed
robertIsaac opened this issue Dec 30, 2020 · 1 comment · Fixed by #21479
Closed

update to google fonts version 2 #21478

robertIsaac opened this issue Dec 30, 2020 · 1 comment · Fixed by #21479
Assignees
@crisbeto
Labels
area: ng-add Issues related to `ng-add` integration feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@robertIsaac
Copy link

Feature Description

now when you run ng add @angular/materia and select yes for Set up global Angular Material typography styles? it adds version 1 of google fonts, while now there is a newer version

most importantly it doesn't include the <link rel="preconnect" href="https://fonts.gstatic.com"> that should makes improvement for loading the fonts and reducing First Contentful Paint time according to web.dev

Use Case

i'm not sure how this works, but currently the output is

<link href="https://fonts.googleapis.com/css?family=Roboto:300,400,500&display=swap" rel="stylesheet">

but it should be

<link rel="preconnect" href="https://fonts.gstatic.com">
<link href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500&display=swap" rel="stylesheet">

if anyone can point me to the right direction i can do the PL myself
@robertIsaac robertIsaac added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Dec 30, 2020
@crisbeto crisbeto self-assigned this Dec 30, 2020
@crisbeto crisbeto added area: cdk/schematics cdk/schematics is *not* a public API has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: ng-add Issues related to `ng-add` integration and removed needs triage This issue needs to be triaged by the team area: cdk/schematics cdk/schematics is *not* a public API labels Dec 30, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 30, 2020
@crisbeto
feat(material/schematics): use newer Google Fonts version
8f47f18 
Switches the schematics, guides and internal dev apps to use the second version of the
Google Fonts loading snippet.

Fixes angular#21478.
@crisbeto crisbeto mentioned this issue Dec 30, 2020
Merged
annieyw pushed a commit that referenced this issue Jan 7, 2021
@crisbeto
feat(material/schematics): use newer Google Fonts version (#21479)
461602d 
Switches the schematics, guides and internal dev apps to use the second version of the
Google Fonts loading snippet.

Fixes #21478.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Jan 14, 2021
@crisbeto @wagnermaciel
feat(material/schematics): use newer Google Fonts version (angular#21479
56da939 
)

Switches the schematics, guides and internal dev apps to use the second version of the
Google Fonts loading snippet.

Fixes angular#21478.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: ng-add Issues related to `ng-add` integration feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(material/schematics): use newer Google Fonts version crisbeto/material2
2 participants
@crisbeto @robertIsaac