Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(mdc-snack-bar): Still uses legacy mat-button #22024

Closed
kseamon opened this issue Feb 25, 2021 · 1 comment · Fixed by #21442 or livepoll/live-poll#189
Closed

bug(mdc-snack-bar): Still uses legacy mat-button #22024

kseamon opened this issue Feb 25, 2021 · 1 comment · Fixed by #21442 or livepoll/live-poll#189
Assignees
@annieyw
Labels
area: material/button G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround

Comments

@kseamon
Copy link
Collaborator

kseamon commented Feb 25, 2021

Expected Behavior

Should use the mdc MatButtonModule

Actual Behavior

Uses the legacy MatButtonModule
https://github.com/angular/components/blob/master/src/material-experimental/mdc-snack-bar/module.ts

This might be because CSS selectors in the MDC button theme are more specific than the selectors that set the color for the snack bar action. So simply updating the module will not work - it will require some tweaks to the snack bar Sass theme to increase selectivity of the Action button selector (https://github.com/angular/components/blob/master/src/material-experimental/mdc-snack-bar/_snack-bar-theme.scss#L39)

This is blocking internal issue b/181260087

Environment

  • Angular: any
  • CDK/Material: 11
  • Browser(s): any
  • Operating System (e.g. Windows, macOS, Ubuntu): any
@kseamon kseamon added the needs triage This issue needs to be triaged by the team label Feb 25, 2021
@jelbourn jelbourn added area: material/button G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround and removed needs triage This issue needs to be triaged by the team labels Feb 25, 2021
@annieyw annieyw mentioned this issue Feb 26, 2021
Closed
@annieyw annieyw added the has pr label Feb 26, 2021
@annieyw annieyw mentioned this issue Feb 26, 2021
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2021
@crisbeto
fix(material-experimental/mdc-snack-bar): use MDC-based button
c4df183 
Switches the MDC-based snack bar to use the MDC-based button. In general we should
be using the MDC versions of components together, when possible.

Fixes angular#22024
annieyw pushed a commit that referenced this issue Mar 5, 2021
@crisbeto
fix(material-experimental/mdc-snack-bar): use MDC-based button (#21442)
9f879b2 
Switches the MDC-based snack bar to use the MDC-based button. In general we should
be using the MDC versions of components together, when possible.

Fixes #22024
This was referenced Mar 17, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@annieyw annieyw

Labels
area: material/button G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material-experimental/mdc-snack-bar): use MDC-based button crisbeto/material2
Bump @angular/cdk from 11.2.4 to 11.2.5 livepoll/live-poll
fix(material-experimental/mdc-snack-bar): use mdc-button instead of l… annieyw/components
Bump @angular/cdk from 11.2.2 to 11.2.5 in /src ToWipf/ToWipf.github.io
Bump @angular/cdk from 11.2.2 to 11.2.5 QutEcoacoustics/workbench-client
Bump @angular/google-maps from 11.2.2 to 11.2.5 QutEcoacoustics/workbench-client
build(deps): Bump @angular/material from 11.2.4 to 11.2.5 peavers-archive/terrible-angular-template
Bump @angular/cdk from 10.2.7 to 11.2.5 umr-dbs/wave
Bump @angular/material from 11.2.3 to 11.2.5 blockbasti/Audio4Live
Bump @angular/cdk from 11.2.4 to 11.2.5 frango9000/pokedex-ng
3 participants
@jelbourn @kseamon @annieyw