Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdk/schematics: wrong css class in cdk drag drop generator #22269

Closed
jhthompson opened this issue Mar 18, 2021 · 1 comment · Fixed by #22270
Closed

cdk/schematics: wrong css class in cdk drag drop generator #22269

jhthompson opened this issue Mar 18, 2021 · 1 comment · Fixed by #22270
Labels
area: cdk/schematics cdk/schematics is *not* a public API P2 The issue is important to a large percentage of users, with a workaround

Comments

@jhthompson
Copy link
Contributor

jhthompson commented Mar 18, 2021 •
edited

Overview

Was playing around with the schematics for the cdk drag drop generator (https://material.angular.io/guide/schematics#drag-and-drop-schematic), and noticed that the generated component's CSS class to "Animate items as they're being sorted" was not working out of the box

The generated CSS selector is .cdk-drop-dragging .cdk-drag but the latest docs (https://material.angular.io/cdk/drag-drop/overview#animations) reference .cdk-drop-list-dragging .cdk-drag
@jhthompson jhthompson changed the title (bug) wrong css class in cdk drag drop generator Wrong css class in cdk drag drop generator Mar 18, 2021
@jhthompson jhthompson mentioned this issue Mar 18, 2021
Merged
@Splaktar Splaktar changed the title Wrong css class in cdk drag drop generator cdk/schematics: wrong css class in cdk drag drop generator Mar 18, 2021
@Splaktar Splaktar added area: cdk/schematics cdk/schematics is *not* a public API P2 The issue is important to a large percentage of users, with a workaround labels Mar 18, 2021
andrewseguin pushed a commit that referenced this issue Mar 19, 2021
@jhthompson
fix(cdk/schematics): update generated css class (#22270)
44cbab0 
Updates the generated CSS class to match the current version.

Fixes #22269
andrewseguin pushed a commit that referenced this issue Mar 19, 2021
@jhthompson @andrewseguin
fix(cdk/schematics): update generated css class (#22270)
5b94af2 
Updates the generated CSS class to match the current version.

Fixes #22269

(cherry picked from commit 44cbab0)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: cdk/schematics cdk/schematics is *not* a public API P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cdk/schematics): update generated css class
2 participants
@Splaktar @jhthompson