Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/testing): create a webdriver harness environment #22321

Merged
merged 5 commits into from
Mar 25, 2021
Merged

feat(cdk/testing): create a webdriver harness environment #22321

merged 5 commits into from
Mar 25, 2021

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba requested review from devversion, jelbourn and a team as code owners March 23, 2021 23:23
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 23, 2021
crisbeto
crisbeto reviewed Mar 24, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, the tests aren't being run anywhere. Would that come in a follow-up?

@mmalerba
Copy link
Contributor Author

yes, this is a new feature branch where I'll be working on getting the tests running and then passing

@mmalerba mmalerba added the target: feature This PR is targeted for a feature branch (outside of main and semver branches) label Mar 24, 2021
jelbourn
jelbourn reviewed Mar 24, 2021
View reviewed changes
src/cdk/testing/webdriver/webdriver-element.ts Outdated Show resolved Hide resolved
src/cdk/testing/webdriver/webdriver-element.ts Outdated Show resolved Hide resolved
src/cdk/testing/webdriver/webdriver-element.ts Outdated Show resolved Hide resolved
src/cdk/testing/webdriver/webdriver-element.ts Outdated Show resolved Hide resolved
src/cdk/testing/webdriver/webdriver-element.ts Outdated Show resolved Hide resolved
src/cdk/testing/webdriver/webdriver-element.ts Outdated Show resolved Hide resolved
src/cdk/testing/webdriver/webdriver-harness-environment.ts Outdated Show resolved Hide resolved
src/cdk/testing/webdriver/webdriver-harness-environment.ts Outdated Show resolved Hide resolved
@mmalerba
Copy link
Contributor Author

Comments addressed, PTAL

jelbourn
jelbourn approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 104cd8b into angular:webdriver-harness-environment Mar 25, 2021
@mmalerba mmalerba deleted the webdriver branch March 25, 2021 17:10
mmalerba added a commit that referenced this pull request Mar 31, 2021
@mmalerba
feat(cdk/testing): create a webdriver harness environment (#22321)
818e87c
mmalerba added a commit that referenced this pull request Apr 8, 2021
@mmalerba @devversion
feat(cdk/testing): create a webdriver harness environment (#22410)
91969f3 
* feat(cdk/testing): create a webdriver harness environment (#22321)

* test(cdk/testing): Get webdriver test suite running with dummy tests (#22344)

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>

* test(cdk/testing): start the e2e-app and run webdriver tests in bazel (#22367)

* test(cdk/testing): port the protractor tests to the webdriver env (#22375)

* test(cdk/testing): enable webdriver tests on CI (#22379)

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>

* fixup! test(cdk/testing): enable webdriver tests on CI (#22379)

Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion devversion is a code owner

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmalerba @jelbourn @crisbeto