Skip to content

feat(cdk/testing): create a webdriver harness environment #22410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 8, 2021
Merged

feat(cdk/testing): create a webdriver harness environment #22410

merged 6 commits into from
Apr 8, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Apr 6, 2021

No description provided.

@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Apr 6, 2021
@mmalerba mmalerba marked this pull request as ready for review April 6, 2021 16:26
@mmalerba mmalerba requested review from devversion, jelbourn and a team as code owners April 6, 2021 16:26
@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 6, 2021
@mmalerba
Copy link
Contributor Author

mmalerba commented Apr 6, 2021

@jelbourn @devversion this is ready for final review to merge the feature branch

devversion
devversion approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 6, 2021
@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 6, 2021
jelbourn
jelbourn approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/cdk/testing/webdriver/webdriver-element.ts
readonly element: () => webdriver.WebElement,
private _stabilize: () => Promise<void>) {}

async blur(): Promise<void> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do our API docs take the description from TestElement, or do we need to duplicate them here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it does not grab the description. This is an issue for the other environments too so I'll fix it in a follow-up

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 7, 2021
@mmalerba mmalerba merged commit 91969f3 into master Apr 8, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @jelbourn @devversion