Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(material/select): incorrect or missing SELECT_ITEM_HEIGHT_EM migration for v12 #22787

Closed
DenysVuika opened this issue May 25, 2021 · 4 comments
Labels
needs triage This issue needs to be triaged by the team

Comments

@DenysVuika
Copy link

When upgrading from Angular Components 11 to 12, the SELECT_ITEM_HEIGHT_EM constant is not exported from the @angular/material/select anymore and the projects that rely on this constant won't compile.

Expected Behavior

What behavior were you expecting to see?

The upgrade tools fix the namespace to be @angular/material/select/select, or export the constant properly from the @angular/material/select

Actual Behavior

Compilation issues as constant is no longer exported

@DenysVuika DenysVuika added the needs triage This issue needs to be triaged by the team label May 25, 2021
@DenysVuika DenysVuika changed the title bug(select): incorrect or missing SELECT_ITEM_HEIGHT_EM migration for v12 bug(material/select): incorrect or missing SELECT_ITEM_HEIGHT_EM migration for v12 May 25, 2021
@jelbourn
Copy link
Member

This was an intentional removal of a deprecated symbol in v12: #21827.

It does look like there was a bug with our changelog script, though, that didn't include this in the changelog.

@HaidarZ
Copy link

HaidarZ commented May 27, 2021

Why it has been removed despite it's still used inside the select component code.

@angelaki
Copy link

angelaki commented Jun 1, 2021

Any news on this?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage This issue needs to be triaged by the team
Projects
None yet
Development

No branches or pull requests

4 participants