Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular and material 11 support. #18

Closed
intermx-vignesh opened this issue May 10, 2021 · 8 comments · Fixed by #20
Closed

Angular and material 11 support. #18

intermx-vignesh opened this issue May 10, 2021 · 8 comments · Fixed by #20

Comments

@intermx-vignesh
Copy link

I don't see a big issues in updating the dependency list to support the latest angular versions.

Is there a breaking change that prevents this project from being updated? would try to help if that's the case.

I inherited a codebase from someone else which made heavy usage of this plugin and now I'm trying to update to Angular 11.

@HaidarZ
Copy link
Owner

HaidarZ commented May 10, 2021

Hello,
I'll work on updating the library to latest angular as soon as possible.
Just need some time to check if there's any breaking change.

@intermx-vignesh
Copy link
Author

I forgot to thank you for your work on this plugin. Thanks again for your response.

@Khazii
Copy link

Khazii commented May 13, 2021

Hi,

Since this issue was opened Angular is now v12, I had no issues with this package on v11 but it seems Material has removed/changed some exports that this package was dependent on since updating to 12.

./node_modules/ng-mat-select-infinite-scroll/__ivy_ngcc__/fesm2015/ng-mat-select-infinite-scroll.js:17:34-55 - Error: export 'SELECT_ITEM_HEIGHT_EM' (imported as 'SELECT_ITEM_HEIGHT_EM') was not found in '@angular/material/select' (possible exports: MAT_SELECT_CONFIG, MAT_SELECT_SCROLL_STRATEGY, MAT_SELECT_SCROLL_STRATEGY_PROVIDER, MAT_SELECT_SCROLL_STRATEGY_PROVIDER_FACTORY, MAT_SELECT_TRIGGER, MatSelect, MatSelectChange, MatSelectModule, MatSelectTrigger, _MatSelectBase, matSelectAnimations)

./node_modules/ng-mat-select-infinite-scroll/__ivy_ngcc__/fesm2015/ng-mat-select-infinite-scroll.js:66:67-88 - Error: export 'SELECT_ITEM_HEIGHT_EM' (imported as 'SELECT_ITEM_HEIGHT_EM') was not found in '@angular/material/select' (possible exports: MAT_SELECT_CONFIG, MAT_SELECT_SCROLL_STRATEGY, MAT_SELECT_SCROLL_STRATEGY_PROVIDER, MAT_SELECT_SCROLL_STRATEGY_PROVIDER_FACTORY, MAT_SELECT_TRIGGER, MatSelect, MatSelectChange, MatSelectModule, MatSelectTrigger, _MatSelectBase, matSelectAnimations)

Hope this helps

@angelaki
Copy link

Any estimations when this library gets updated? Would love to upgrade to ng12

@angelaki
Copy link

Any news on this? @Khazii have you found a solution, yet? Or still waiting for this to get updated, too?

@parse
Copy link
Contributor

parse commented May 25, 2021

@angelaki I just submitted a PR that contains a fix.

@angelaki
Copy link

Just seen it! Super cool - thank you!

@HaidarZ
Copy link
Owner

HaidarZ commented May 26, 2021

I'm working on the workaround, will be out soon.
This issue is related to the angular/material bug angular/components#22787

@akhjamil akhjamil mentioned this issue Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants