Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(typography): deprecated typography config doesn't pass input level to underlying config function #23216

Open
lagatchell opened this issue Jul 22, 2021 · 1 comment
Open

bug(typography): deprecated typography config doesn't pass input level to underlying config function #23216

lagatchell opened this issue Jul 22, 2021 · 1 comment
Labels
area: theming P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@lagatchell
Copy link
Contributor

lagatchell commented Jul 22, 2021 •
edited

Reproduction

Steps to reproduce:

  1. Define a typography config in styles.scss and add a typography level for $input
$custom-typography: mat-typography-config(
  $input: mat-typography-level(14px, 1.25, 400)
);
  1. Add @debug to print the resulting configuration
@debug $custom-typography;
  1. npm start
  2. Notice that the typography level for input is still the default
    image

Expected Behavior

The mat-topography-config function should correctly apply a mat-typography-level for $input.

Actual Behavior

$input argument is ignored, because it is never passed to the underlying define-typography-config function.
https://github.com/angular/components/blob/12.0.x/src/material/core/typography/_typography-deprecated.scss#L36

I would be willing to contribute a fix for this issue.

Environment

  • Angular: 12.x
  • CDK/Material: 12.x
  • Browser(s): All
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@lagatchell lagatchell added the needs triage This issue needs to be triaged by the team label Jul 22, 2021
lagatchell added a commit to lagatchell/components that referenced this issue Jul 22, 2021
@lagatchell
fix(material/typography): correctly configure input typography level
e6bee01 
angular#23216
@lagatchell lagatchell mentioned this issue Jul 22, 2021
Merged
lagatchell added a commit to lagatchell/components that referenced this issue Jul 22, 2021
@lagatchell
fix(material/theming): correctly configure input typography level
d914a0f 
angular#23216
@crisbeto crisbeto added area: theming has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Jul 22, 2021
mmalerba pushed a commit that referenced this issue Jul 28, 2021
@lagatchell
fix(material/theming): correctly configure input typography level (#2…
0e3bd88 
…3217)

#23216
mmalerba pushed a commit that referenced this issue Jul 28, 2021
@lagatchell @mmalerba
fix(material/theming): correctly configure input typography level (#2…
b055ac7 
…3217)

#23216

(cherry picked from commit 0e3bd88)
@mmalerba mmalerba removed the has pr label Dec 8, 2022
@ShiftyMcCool
Copy link

Just encountered this issue, any update on the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: theming P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ShiftyMcCool @crisbeto @lagatchell @mmalerba