Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(mat-chip): Cannot shift+tab out of a focused mat-chip-listbox #26698

Closed
1 task done
menuka-s opened this issue Feb 27, 2023 · 1 comment · Fixed by #26727
Closed
1 task done

bug(mat-chip): Cannot shift+tab out of a focused mat-chip-listbox #26698

menuka-s opened this issue Feb 27, 2023 · 1 comment · Fixed by #26727
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) area: material/chips P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@menuka-s
Copy link

menuka-s commented Feb 27, 2023 •
edited

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

14.2.7

Description

When focused in a <mat-chip-listbox> a user cannot shift+tab to the previous element.

Reproduction

Steps to reproduce:

  1. Tab to <mat-chip-listbox>
  2. Try shift+tab to tab out of the <mat-chip-listbox>

Stackblitz

Expected Behavior

A user should be able to press shift+tab to focus back to the previous element.

Actual Behavior

When pressing shift+tab, the focus remains on a the <mat-chip-listbox>. If a value is selected, then the focus returns to that selected <mat-chip>.

Environment

  • Angular: 15
  • CDK/Material: 15.2
  • Browser(s): Chrome, Edge, Firefox
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@menuka-s menuka-s added the needs triage This issue needs to be triaged by the team label Feb 27, 2023
@crisbeto crisbeto self-assigned this Mar 3, 2023
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) area: material/chips and removed needs triage This issue needs to be triaged by the team labels Mar 3, 2023
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 3, 2023
@crisbeto
fix(material/chips): unable to shift + tab out of a chip set
fe0aa69 
Fixes that it wasn't possible for the user to use shift + tab to move out of a chip set. We had some logic to handle it already, but it was resetting the tabindex before focus has a chance to escape.

Fixes angular#26698.
@crisbeto crisbeto mentioned this issue Mar 5, 2023
Merged
crisbeto added a commit that referenced this issue Mar 6, 2023
@crisbeto
fix(material/chips): unable to shift + tab out of a chip set (#26727)
168619b 
Fixes that it wasn't possible for the user to use shift + tab to move out of a chip set. We had some logic to handle it already, but it was resetting the tabindex before focus has a chance to escape.

Fixes #26698.
crisbeto added a commit that referenced this issue Mar 6, 2023
@crisbeto
fix(material/chips): unable to shift + tab out of a chip set (#26727)
e7612c7 
Fixes that it wasn't possible for the user to use shift + tab to move out of a chip set. We had some logic to handle it already, but it was resetting the tabindex before focus has a chance to escape.

Fixes #26698.

(cherry picked from commit 168619b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) area: material/chips P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/chips): unable to shift + tab out of a chip set crisbeto/material2
2 participants
@crisbeto @menuka-s