Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(matTabLink): disabled flag does not work #27071

Closed
1 task done
fbuscaroli2 opened this issue May 10, 2023 · 2 comments · Fixed by #27091
Closed
1 task done

bug(matTabLink): disabled flag does not work #27071

fbuscaroli2 opened this issue May 10, 2023 · 2 comments · Fixed by #27091
Labels
area: material/tabs P4 A relatively minor issue that is not relevant to core functions

Comments

@fbuscaroli2
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

14.x

Description

the mat-tab-link disabled flag does not prevent click

Reproduction

Steps to reproduce:

  1. Add a (click) action to a mat-tab-link

Expected Behavior

The click action should not occur.

Actual Behavior

The click action is executed any way.

Environment

  • Angular: 16
  • CDK/Material: 16
  • Browser(s): Edge
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@fbuscaroli2 fbuscaroli2 added the needs triage This issue needs to be triaged by the team label May 10, 2023
@amysorto amysorto added P4 A relatively minor issue that is not relevant to core functions area: material/tabs and removed needs triage This issue needs to be triaged by the team labels May 11, 2023
@amysorto
Copy link
Contributor

Binding to the click event still works for mat-tab-link when disabled in v16.0.1

naaajii added a commit to naaajii/components that referenced this issue May 13, 2023
@naaajii
fix(material/tabs): tab header is clickable if its disable
80d7986 
Prior this commit disabled tab header content is clickable and causing event when it shouldn't

Fixes angular#27071
@naaajii naaajii mentioned this issue May 13, 2023
Merged
crisbeto pushed a commit that referenced this issue Jun 6, 2023
@naaajii @crisbeto
fix(material/tabs): tab header is clickable if its disable (#27091)
b6a9895 
Prior this commit disabled tab header content is clickable and causing event when it shouldn't

Fixes #27071

(cherry picked from commit 06aa8e5)
crisbeto pushed a commit that referenced this issue Jun 6, 2023
@naaajii
fix(material/tabs): tab header is clickable if its disable (#27091)
06aa8e5 
Prior this commit disabled tab header content is clickable and causing event when it shouldn't

Fixes #27071
@smorandi smorandi mentioned this issue Jun 9, 2023
Closed
1 task
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: material/tabs P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/tabs): tab header is clickable if its disable naaajii/components
2 participants
@amysorto @fbuscaroli2