Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus/Selects/ExpansionPanel should follow Material guidelines #3814

Open
Ploppy3 opened this issue Mar 28, 2017 · 3 comments
Open

Menus/Selects/ExpansionPanel should follow Material guidelines #3814

Ploppy3 opened this issue Mar 28, 2017 · 3 comments
Labels
area: many Area label for issues related to many components P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Ploppy3
Copy link

Ploppy3 commented Mar 28, 2017

Bug:

What is the expected behavior?

The components should follow the Material guidelines

What is the current behavior?

For Menu/Select/ExpansionPanel:

  • Shadows seem incorrect
  • Missing border-radius

For Menu/Select:

  • Wrong animations.

Current Menu animation:
image

Menu Animation according to the Material Guidelines:
image

Current Select animation:
image

Select Animation according to the Material Guidelines:
image

Which versions of Angular, Material, OS, browsers are affected?

Material 5.0.0-rc0

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 1, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 25, 2017
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by:
* Reducing the elevation from 8 to 3.
* Adding a slight border radius.
* Tweaking the animation to match the examples.

Relates to angular#3814.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 26, 2017
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by:
* Reducing the elevation from 8 to 3.
* Adding a slight border radius.
* Tweaking the animation to match the examples.

Relates to angular#3814.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 1, 2017
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by:
* Reducing the elevation from 8 to 3.
* Adding a slight border radius.
* Tweaking the animation to match the examples.

Relates to angular#3814.
mmalerba pushed a commit that referenced this issue Jul 6, 2017
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by:
* Reducing the elevation from 8 to 3.
* Adding a slight border radius.
* Tweaking the animation to match the examples.

Relates to #3814.
jelbourn pushed a commit that referenced this issue Jul 14, 2017
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by:
* Reducing the elevation from 8 to 3.
* Adding a slight border radius.
* Tweaking the animation to match the examples.

Relates to #3814.
jelbourn pushed a commit that referenced this issue Jul 14, 2017
Aligns the menu panel appearance with [the spec](https://material.io/guidelines/components/menus.html) by:
* Reducing the elevation from 8 to 3.
* Adding a slight border radius.
* Tweaking the animation to match the examples.

Relates to #3814.
@Ploppy3
Copy link
Author

Ploppy3 commented Nov 15, 2017

@crisbeto Is it also possible to apply the same fixes to the Expansion Panel, missing border radius, wrong shadows, and separator hardly visible :
image
(from material guidelines)

@Ploppy3 Ploppy3 changed the title Menus & Selects open animations are incorrect according to the Material Guidelines. Menus/Selects/ExpansionPanel should follow Material guidelines Nov 20, 2017
@Ploppy3
Copy link
Author

Ploppy3 commented Nov 20, 2017

@crisbeto Update the issue so that it concerns the 3 components.

@thw0rted
Copy link

thw0rted commented Jan 9, 2018

I am also looking to style the Expansion Panel's description (while collapsed) in line with how the spec presents it. I don't think the spec ever actually states that the description portion of multiple panels in the same "group" (grouping of multiple panels is also never specifically mentioned in the spec...) must align in a column with each other, but each example image does exhibit this behavior.

The current implementation just allows each panel's title and description fields to resize according to their content, which means that the descriptions will never line up with each other. This can be seen in the docs examples and gets really pronounced with many panels of varying title width. I have used a variant of the fix described in #5173 (flex-basis: 0) but the fundamental problem is that you have to know ahead of time approximately how large your title content will be, because you still either accept the default title width (which is small) or need to define a min-width manually. I don't see a clean way to automatically select a common title width among all grouped panels, but would love to be proven wrong.

@andrewseguin andrewseguin added the area: many Area label for issues related to many components label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: many Area label for issues related to many components P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

5 participants