Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planned features for md-table #5882

Closed
AmirTugi opened this issue Jul 19, 2017 · 6 comments
Closed

Planned features for md-table #5882

AmirTugi opened this issue Jul 19, 2017 · 6 comments

Comments

@AmirTugi
Copy link

I would like to know what features are currently planned for the md-table.
As mentioned here, it seems to me that there a few features in the spec that are not currently planned:

  • Contextual-header (as in here, under 'alternative headers')
  • Row selection (along with an overall checkbox to de/select-all)

The latter is rather easy to implement, maybe I'll even help implementing it.
The former, though, I think should be handled by you.

If anyone has more features to propose, maybe raise them here as I haven't seen any discussion regarding this.

@willshowell
Copy link
Contributor

Both of those will be included in an docs example soon! #5848 (comment)

@andrewseguin
Copy link
Contributor

I've opened up issues for table features that we'd love to see added, please feel free to open more issues for any features you would like to see and we can discuss on each issue. Closing this since it will be difficult to have a discussion here on each issue.

#5885, #5886, #5887, #5888, #5889, #5890, #5891

Note that a contextual header will likely be included as part of a simple table but will be highly opinionated. Every project has its own idea of how the header should look and behave, which can be seen even in the Material spec where there are several versions of how it can look. It will unlikely be an official component.

Also, selection is already supported through the SelectionModel . Check out the example in the PR linked by @willshowell for an example of using it

@matheo
Copy link

matheo commented Jul 22, 2017

Any idea why the md-table is not refreshing its contents in this case:

I have my table to list my items (/admin/users route)
with action buttons to a form (./create and [row.id, 'edit'] routes), all fine.

But when I navigate back, like with a Cancel Button with routerLink="../"
the table doesn't load anything, not even the headers and doesn't invoke the DataSource.connect() either. I'm missing something? my component seems to load Ok, but md-table needs something here :(

@benb7760
Copy link

@matheo This is already reported as #5593 and has a PR #5775

@matheo
Copy link

matheo commented Jul 22, 2017

@benb7760 How sweet, thanks a ton!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants