fix(form-field): make outline appearance work in situations where the… #10943
Conversation
… form field is not initially in the DOM
mmalerba
added
P1
googlebot
added
the
cla: yes
src/lib/form-field/form-field.ts
Outdated
| @@ -419,6 +419,9 @@ export class MatFormField extends _MatFormFieldMixinBase | |||
| // getBoundingClientRect isn't available on the server. | |||
| return; | |||
| } | |||
| if (!document.contains(this._elementRef.nativeElement)) { | |||
There was a problem hiding this comment.
This one'll probably throw in Universal.
There was a problem hiding this comment.
The line above is returning if we're not in the browser
| @@ -195,6 +195,8 @@ export class MatFormField extends _MatFormFieldMixinBase | |||
|
|
|||
| _outlineGapStart = 0; | |||
|
|
|||
| _initialGapCalculated = false; | |||
There was a problem hiding this comment.
Rather than adding another property, couldn't we get away with checking that the gap is greater than 0?
There was a problem hiding this comment.
Currently that would cause a check loop for other types of form-field, since they set the gap to 0. I could set it to 1 or some other number in that case since its not really used, but this just seemed clearer
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
… form field is not initially in the DOM.
fixes #10498