Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidenav): box shadow visible while closed when rendering on the server #10969

Merged
merged 1 commit into from May 1, 2018

Conversation

crisbeto
Copy link
Member

Fixes the box-shadow of a sidenav being visible while it's closed when it's being rendered on the server.

Fixes #10760.

…erver

Fixes the `box-shadow` of a sidenav being visible while it's closed when it's being rendered on the server.

Fixes angular#10760.
@crisbeto crisbeto requested a review from mmalerba as a code owner April 24, 2018 01:37
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 24, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Apr 24, 2018
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Apr 26, 2018
@josephperrott josephperrott removed the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label May 1, 2018
@josephperrott josephperrott merged commit cfe6c1d into angular:master May 1, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal rendered sidenav showing box-shadow in closed state
5 participants