Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tree): add theme to angular-material-theme mixin #11015

Merged
merged 1 commit into from Apr 26, 2018
Merged

fix(tree): add theme to angular-material-theme mixin #11015

merged 1 commit into from Apr 26, 2018

Conversation

tinayuangao
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 25, 2018
jelbourn
jelbourn approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you change the commit message to

fix(tree): add theme to angular-material-theme mixin

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 25, 2018
@jelbourn jelbourn added this to the 6.0 milestone Apr 25, 2018
@crisbeto
Copy link
Member

If we want it to be consistent with all the components, it also needs a typography mixin. The mixin itself can be left empty.

@tinayuangao tinayuangao changed the title fix(tree): add tree theme fix(tree): add theme to angular-material-theme mixin Apr 25, 2018
@tinayuangao
Copy link
Contributor Author

Thanks for review! Comments addressed.

@andrewseguin andrewseguin merged commit a292d31 into angular:master Apr 26, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tinayuangao @crisbeto @jelbourn @googlebot @andrewseguin