fix(drag-drop): avoid interfering with element clicks #13152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Sep 18, 2018
src/cdk/drag-drop/drag.ts
Outdated
| * Minimum amount of pixels that the user should | ||
| * drag, before the CDK initiates a drag sequence. | ||
| */ | ||
| minimumDragDistance: number; |
There was a problem hiding this comment.
What do you think of dragStartThreshold?
src/cdk/drag-drop/drag.ts
Outdated
| * @param referenceElement Element that started the drag sequence. | ||
| * @param event Browser event object that started the sequence. | ||
| */ | ||
| private _prepareDragSequence(referenceElement: HTMLElement, event: MouseEvent | TouchEvent) { |
There was a problem hiding this comment.
How about _resetDragSequence or _initializeDragSequence?
There was a problem hiding this comment.
I went with _initializeDragSequence. _resetDragSequence sounds like something you'd call once the sequence is done.
Resolves a long-standing TODO about starting the drag&drop sequence after the user has dragged over a certain amount of pixels, rather than starting it immediately on `mousedown`/`touchstart`. This prevents random clicks and taps on the element from being interpreted as dragging and avoids potentially interrupting the native click events on children of `CdkDrag`.
crisbeto
force-pushed
the
drag-drop-min-distance
branch
from
ec36d42
to
32c55de
Compare
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
Resolves a long-standing TODO about starting the drag&drop sequence after the user has dragged over a certain amount of pixels, rather than starting it immediately on `mousedown`/`touchstart`. This prevents random clicks and taps on the element from being interpreted as dragging and avoids potentially interrupting the native click events on children of `CdkDrag`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a long-standing TODO about starting the drag&drop sequence after the user has dragged over a certain amount of pixels, rather than starting it immediately on
mousedown/touchstart. This prevents random clicks and taps on the element from being interpreted as dragging and avoids potentially interrupting the native click events on children ofCdkDrag.