Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-field): users being able to select the hidden placeholder of disabled input #13480

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 7, 2018

Prevents the users from being able to select the hidden placeholder text by double-clicking on a disabled input.

Fixes #13479.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 7, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 7, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 7, 2018
@ngbot
Copy link

ngbot bot commented Nov 3, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

… disabled input

Prevents the users from being able to select the hidden placeholder text by double-clicking on a disabled input.

Fixes angular#13479.
@crisbeto crisbeto force-pushed the 13479/disabled-input-placeholder-select branch from 2ce7055 to 879a075 Compare November 11, 2018 21:24
@andrewseguin andrewseguin merged commit 8dc367c into angular:master Nov 14, 2018
IlCallo pushed a commit to IlCallo/material2 that referenced this pull request Nov 15, 2018
… disabled input (angular#13480)

Prevents the users from being able to select the hidden placeholder text by double-clicking on a disabled input.

Fixes angular#13479.
josephperrott pushed a commit that referenced this pull request Nov 19, 2018
… disabled input (#13480)

Prevents the users from being able to select the hidden placeholder text by double-clicking on a disabled input.

Fixes #13479.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(mat-form-field): placeholder and mat-label are overlaping
4 participants