Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): add the ability to customize the animation duration #13505

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 9, 2018

Adds the animationDuration input and the MAT_TABS_CONFIG injection token that can be used to configure the duration of the tab animation.

Fixes #13428.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Oct 9, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 9, 2018
Adds the `animationDuration` input and the `MAT_TABS_CONFIG` injection token that can be used to configure the duration of the tab animation.

Fixes angular#13428.
@crisbeto crisbeto force-pushed the 13428/tabs-animation-duration branch from 7b71cfb to 281813c Compare October 9, 2018 10:47
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround labels Oct 10, 2018
@mmalerba mmalerba merged commit 0cd7536 into angular:master Oct 23, 2018
@mptardy
Copy link

mptardy commented Nov 9, 2018

@mmalerba can you please merge that into the 7.0.x branch and release a new version?

@jelbourn
Copy link
Member

@mptardy the 7.0.x branch is only for patch changes; new features will be included in 7.1

See https://semver.org/

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable tab animations
5 participants