Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): default dialog actions alignment to end #13620

Closed
wants to merge 1 commit into from
Closed

fix(dialog): default dialog actions alignment to end #13620

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Switches to defaulting the alignment for mat-dialog-actions to the end, rather than the start.

Fixes #13618.

@crisbeto crisbeto added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release labels Oct 15, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 15, 2018
@crisbeto
Copy link
Member Author

Caretaker note: we should evaluate how many presubmit issues this causes before we decide whether to merge it in.

jelbourn
jelbourn previously approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I could see this being in a minor release since it's a bug fix, even though it does have a visual change. Will depend on the extend of screenshot diffs. Either way, this shouldn't go in 7.0.0.

@jelbourn jelbourn added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Oct 16, 2018
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release labels Oct 18, 2018
@jelbourn jelbourn removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Nov 2, 2018
@crisbeto crisbeto force-pushed the 13618/dialog-actions-default-alignment branch from c92c8fa to c6bee97 Compare April 8, 2019 20:57
@crisbeto crisbeto mentioned this pull request Apr 17, 2019
Open
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019
@crisbeto crisbeto force-pushed the 13618/dialog-actions-default-alignment branch from c6bee97 to 6959c2d Compare July 9, 2019 20:35
@crisbeto
fix(dialog): default dialog actions alignment to end
e30b631 
Switches to defaulting the alignment for `mat-dialog-actions` to the `end`, rather than the `start`.

Fixes angular#13618.
@crisbeto crisbeto force-pushed the 13618/dialog-actions-default-alignment branch from 6959c2d to e30b631 Compare October 3, 2019 19:18
@crisbeto crisbeto mentioned this pull request Apr 21, 2020
Merged
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@andrewseguin andrewseguin added needs rebase and removed P4 A relatively minor issue that is not relevant to core functions labels Mar 28, 2022
@josephperrott josephperrott added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed needs rebase labels Nov 16, 2022
@mmalerba mmalerba self-assigned this Nov 28, 2022
@mmalerba
Copy link
Contributor

Closing since this fix is for the legacy mat-dialog which has been superseded by the MDC based one.

@mmalerba mmalerba closed this Nov 28, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

Assignees

@mmalerba mmalerba

Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dialog] By default, actions display left-aligned
6 participants
@crisbeto @mmalerba @jelbourn @googlebot @josephperrott @andrewseguin