feat: add date adapter for luxon #14681

crisbeto · 2018-12-30T18:27:34Z

Adds the LuxonDateAdapter that can be used to work with Luxon dates in the MatDatepicker.

crisbeto · 2018-12-31T06:22:17Z

src/material-luxon-adapter/BUILD.bazel

+
+load("//tools:defaults.bzl", "ng_module", "ng_package")
+load("//:packages.bzl", "ROLLUP_GLOBALS")
+


@devversion this file is based on the one from the Moment adapter, but I'm not sure whether it's entirely correct. AFAIK this won't run the unit tests.

Can probably update this now, based on #14687

mmalerba · 2019-01-02T18:10:32Z

src/material-luxon-adapter/BUILD.bazel

+
+load("//tools:defaults.bzl", "ng_module", "ng_package")
+load("//:packages.bzl", "ROLLUP_GLOBALS")
+


Can probably update this now, based on #14687

mmalerba · 2019-01-02T18:16:41Z

src/material-luxon-adapter/adapter/luxon-date-adapter.ts

+  }
+
+  getFirstDayOfWeek(): number {
+    return 0;


Maybe leave a comment about Luxon not supporting this

mmalerba · 2019-01-02T18:17:22Z

src/material-luxon-adapter/adapter/luxon-date-adapter.ts

+  }
+
+  clone(date: DateTime): DateTime {
+    return date;


doesn't look like this is actually cloning?

We don't need to clone since the Luxon DateTime is immutable. I'll leave a comment.

I think we still ought to, otherwise d === adapter.clone(d) which feels wrong

Agreed that it should still be a copy

crisbeto · 2019-01-03T13:21:24Z

I've addressed the feedback @mmalerba. Also @devversion can you take a look at the Bazel setup? I've based it off of what you did for the Moment adapter.

devversion

LGTM on the Bazel stuff. Just a few minor nits.

devversion · 2019-01-03T16:47:19Z

src/material-luxon-adapter/BUILD.bazel

+  deps = [
+    "@angular//packages/core",
+    "@matdeps//@types/luxon",
+    "@matdeps//luxon",


We don't need this here (only the types). Moment ships its typings as part of @matdeps//moment

devversion · 2019-01-03T16:48:03Z

src/material-luxon-adapter/BUILD.bazel

+  # Explicitly specify the tsconfig that is also used by Gulp. We need to explicitly use this
+  # tsconfig because in order to import Luxon with TypeScript, we need some special options
+  # enabled.
+  tsconfig = ":tsconfig-build.json",


Maybe my commenting wasn't too clear, but we shouldn't need this here because Luxon doesn't need the synthetic imports mentioned in the tsconfig-build.json of the moment adapter package.

devversion · 2019-01-03T16:48:22Z

src/material-luxon-adapter/BUILD.bazel

+    "//src/lib/testing",
+    "//src/cdk/platform",
+    "@matdeps//@types/luxon",
+    "@matdeps//luxon",


Same as above. Should be able to remove this from here.

jelbourn · 2019-01-08T02:23:13Z

src/material-luxon-adapter/adapter/luxon-date-adapter.ts

+  }
+
+  clone(date: DateTime): DateTime {
+    return date;


Agreed that it should still be a copy

jelbourn · 2019-01-08T02:26:04Z

src/lib/datepicker/datepicker.md

+|---------------------|-----------|-----------------------------------------------------------------------|----------------------------------------|----------------------------------|
+|`MatNativeDateModule`|`Date`     |en-US                                                                  |None                                    |`@angular/material`               |
+|`MatMomentDateModule`|`Moment`   |[See project](https://github.com/moment/moment/tree/develop/src/locale)|[Moment.js](https://momentjs.com/)      |`@angular/material-moment-adapter`|
+|`MatLuxonDateModule` |`DateTime` |[See project](https://moment.github.io/luxon/docs/manual/intl.html)    |[Luxon](https://moment.github.io/luxon/)|`@angular/material-luxon-adapter`|

 *Please note: `MatNativeDateModule` is based off of the functionality available in JavaScript's


We should update this note to just say "...highly recommend using one of the alternative adapters or creating your own custom adapter"

ngbot · 2019-01-09T18:48:48Z

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

ngbot · 2019-01-09T18:50:18Z

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

crisbeto · 2019-01-09T19:17:40Z

@jelbourn @mmalerba I've addressed the feedback. Can you take another look?

mmalerba

LGTM, we should do a follow-up PR to add docs for it

Adds the `LuxonDateAdapter` that can be used to work with Luxon dates in the `MatDatepicker`.

jturekburnett · 2019-04-23T23:00:18Z

src/material-luxon-adapter/adapter/luxon-date-adapter.ts

+  }
+
+  getDayOfWeekNames(style: 'long' | 'short' | 'narrow'): string[] {
+    return Info.weekdays(style, {locale: this.locale});


Not sure if should be changed here or somewhere else, but the way this is, the weekdays on the month view of the calendar don't line up correctly with the dates because it starts on Monday instead of Sunday. For example, April 1, 2019 was on a Monday, but this adapter causes the 'T' for Tuesday to appear above April 1 instead of the 'M'.

dmitry-urenev · 2019-06-06T14:38:13Z

src/material-luxon-adapter/adapter/luxon-date-adapter.ts

+    return Info.months(style, {locale: this.locale});
+  }
+
+  getDateNames(): string[] {


this function might be implemented like this:

Suggested change

getDateNames(): string[] {

public getDateNames(): string[] {

return range(31, day =>

new DateTime()

.set({ month: 1, day })

.setLocale(this.locale)

.toFormat('d')

);

}

LosD · 2019-07-23T07:55:32Z

Blocked pending further discussion on our strategy for supporting multiple date adapters

@andrewseguin Did you ever complete that discussion?

dmitrye · 2019-08-08T06:11:33Z

It would be good for someone to finish this adapter. The current method I had to resort to was to make properties for each Date Input

The html looks like this:

<input matInput id="endDate" formControlName="endDate" name="endDate" placeholder="Select a Date" autocomplete="off"
                               [value]="endDateAsDate" type="text" class="form-control" [matDatepicker]="myEndDatePicker" (focus)="myEndDatePicker.open()">

The .ts file looks like this (converts Luxon DateTime to JSDate/Date object):

  get endDateAsDate(){
    return <Date>(<DateTime>this.f.endDate.value).toJSDate();
  }

It's only needed to set the default value coming back from DB or if you want to preset it to Today. But remembering to do this everywhere doesn't seem sustainable.

Enngage · 2019-08-10T10:15:32Z

+ Luxon date adapter

weihsth · 2019-08-29T13:35:45Z

Is the Luxon date adapter still a topic? Would be really cool... it's 5 month now and no progress anymore(?) =)

DaSchTour · 2019-11-05T13:02:39Z

I think with google maps and youtube player as new modules in this repository there should not be any doubt about adding this module here.

sbarbat · 2020-11-23T13:40:21Z

Hi guys, what is needed to merge this? Happy to help here 😄

LosD · 2020-11-23T13:46:29Z

Hi guys, what is needed to merge this? Happy to help here 😄

@sbarbat unfortunately, it is becoming a standard pattern for this project: Things moving forward nicely, then @andrewseguin coming in with some "we need to discuss this", that discussion apparently never taking place, and everything dying from there on out.

I fully understand the need to design things properly, but if you decide on a discussion, effing HOLD that discussion instead of just letting stuff die for years.

jelbourn · 2020-11-25T04:16:39Z

Status us tracked here: #20599 (comment)

The gist is that there's debate on the team as to whether we should support these adapters, or defer to community implementations.

mtpultz · 2020-12-15T09:37:07Z

@andrewseguin @jelbourn would it not make sense to support at least one new date adapter while you internally decide whether you want to maintain date adapters in the Angular repo, or push these adapters out for the Angular community to maintain? By allowing this PR to continue and be merged in you're not locking Angular into maintaining date adapters.

Supporting Luxon in Angular makes sense since you currently support a Moment date adapter, and Luxon is essentially Moment v2 so all you are doing is providing an update due to a deprecation, which is good practice and a maintenance task. You can still have the discussion and split out the Luxon date adapter into a community repo afterwards, but by having this on hold and opening an internal discussion on whether Angular should or should not support date adapters (that apparently hasn't happened) doesn't stop new projects from perpetuating the use of Moment.

@andrewseguin #14681 (comment) you blocked a PR that was apparently marked ready to merge. With the offers to help from the community and the amount of work already put into this PR this could have been completed and pushed in leaving all sorts of time for an internal discussion that the community isn't privy on where date adapters should live, and it would solve the issue we're having with a deprecated dependency being the only officially supported fluent date adapter in Angular.

@jelbourn #20599 (comment) is an opinion PR that discusses which date library should have a date adapter, but you can't discuss what libraries should have date adapters if internally no decision has been made on whether they should be maintained by Angular or the community.

This PR has support from the community. Please take the hold off to remove the bottleneck on this date adapter so we can adopt a new date adapter, drop a deprecated dependency, and then where everything ends up living can be decided.

andreialecu · 2020-12-20T11:40:40Z

I ended up needing this date adapter as well, and just copied the code from this PR and published it on npm: https://www.npmjs.com/package/ngx-material-luxon

Seems to work for my purposes.

jelbourn · 2020-12-21T19:56:45Z

I would personally like to move forward with this, but I don't have unilateral decision-making power when it comes to publishing new @angular packages, and unfortunately there isn't consensus from the rest of the Angular team that this is something we should work on yet. Overall the team will be in a better position to consider additions like this once ViewEngine (the pre-Ivy rendering engine) is deleted.

Polyterative · 2021-01-20T10:08:26Z

any progress on this?

wiegell · 2021-04-17T15:50:54Z

Any news?

crisbeto · 2021-07-14T18:04:26Z

Closing in favor of #23167.

angular-automatic-lock-bot · 2021-08-14T00:01:56Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto added the in progress This issue is currently in progress label Dec 30, 2018

crisbeto self-assigned this Dec 30, 2018

crisbeto requested review from devversion, jelbourn and mmalerba as code owners December 30, 2018 18:27

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 30, 2018

crisbeto force-pushed the luxon-date-adapter branch 5 times, most recently from 06cf8c8 to f917d7f Compare December 30, 2018 21:13

crisbeto changed the title ~~wip: add date adapter for luxon~~ feat: add date adapter for luxon Dec 31, 2018

crisbeto commented Dec 31, 2018

View reviewed changes

crisbeto assigned jelbourn, devversion and mmalerba and unassigned crisbeto Dec 31, 2018

crisbeto added target: minor This PR is targeted for the next minor release and removed in progress This issue is currently in progress labels Dec 31, 2018

mmalerba reviewed Jan 2, 2019

View reviewed changes

crisbeto force-pushed the luxon-date-adapter branch from f917d7f to 41d9e49 Compare January 3, 2019 13:07

devversion approved these changes Jan 3, 2019

View reviewed changes

crisbeto force-pushed the luxon-date-adapter branch from 41d9e49 to be4a8de Compare January 4, 2019 15:41

jelbourn reviewed Jan 8, 2019

View reviewed changes

crisbeto force-pushed the luxon-date-adapter branch from be4a8de to 753b628 Compare January 9, 2019 19:17

mmalerba approved these changes Jan 9, 2019

View reviewed changes

feat: add date adapter for luxon

16958e2

Adds the `LuxonDateAdapter` that can be used to work with Luxon dates in the `MatDatepicker`.

crisbeto force-pushed the luxon-date-adapter branch from fe7a4d2 to 16958e2 Compare April 5, 2019 20:53

jturekburnett reviewed Apr 23, 2019

View reviewed changes

jelbourn added ༼ つ ◕_◕ ༽つ and removed ༼ つ ◕_◕ ༽つ labels Apr 25, 2019

mmalerba added aaa and removed aaa labels Apr 25, 2019

dmitry-urenev reviewed Jun 6, 2019

View reviewed changes

FrankiePo mentioned this pull request May 11, 2020

WIP: feat: add date adapter for luxon #19326

Closed

mmalerba removed the lgtm label Jul 31, 2020

hakimio mentioned this pull request Dec 15, 2020

help(MomentDateAdapter): Luxon Adapter #21347

Closed

mtpultz mentioned this pull request Dec 15, 2020

feat(datepicker): Add additional date adapter implementations #20599

Open

3 tasks

jeremylcarter mentioned this pull request Jan 6, 2021

datepicker: shows date using provided LOCALE_ID but parses date using default US locale (or a combination of them) #14291

Open

crisbeto closed this Jul 14, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 14, 2021


		load("//tools:defaults.bzl", "ng_module", "ng_package")
		load("//:packages.bzl", "ROLLUP_GLOBALS")

-  getDateNames(): string[] {
+ public getDateNames(): string[] {
+        return range(31, day =>
+            new DateTime()
+                .set({ month: 1, day })
+                .setLocale(this.locale)
+                .toFormat('d')
+        );
+}

feat: add date adapter for luxon #14681

feat: add date adapter for luxon #14681

Conversation

crisbeto commented Dec 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crisbeto Jan 3, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crisbeto commented Jan 3, 2019

devversion left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngbot bot commented Jan 9, 2019

ngbot bot commented Jan 9, 2019

crisbeto commented Jan 9, 2019

mmalerba left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LosD commented Jul 23, 2019 • edited

dmitrye commented Aug 8, 2019

Enngage commented Aug 10, 2019 • edited

weihsth commented Aug 29, 2019 • edited

DaSchTour commented Nov 5, 2019

sbarbat commented Nov 23, 2020

LosD commented Nov 23, 2020

jelbourn commented Nov 25, 2020

mtpultz commented Dec 15, 2020 • edited

andreialecu commented Dec 20, 2020

jelbourn commented Dec 21, 2020

Polyterative commented Jan 20, 2021

wiegell commented Apr 17, 2021

crisbeto commented Jul 14, 2021

angular-automatic-lock-bot bot commented Aug 14, 2021

crisbeto Jan 3, 2019 •

edited

LosD commented Jul 23, 2019 •

edited

Enngage commented Aug 10, 2019 •

edited

weihsth commented Aug 29, 2019 •

edited

mtpultz commented Dec 15, 2020 •

edited