New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tree): rework to account for ivy changes #15503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
the
P2
The issue is important to a large percentage of users, with a workaround
label
Mar 16, 2019
googlebot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Mar 16, 2019
crisbeto
force-pushed
the
tree-ivy-refactor
branch
from
March 16, 2019 15:22
573cb05
to
e651262
Compare
Reworks the `MatTree` and `CdkTree` components to account for some of the changes in Ivy. This includes: * Changing the padding directive to account for a different time at which static inputs are initialized. * Changing the toggle directive to account for inheritance of host listeners working differently. * Switching to `Default` change detection, because the way embedded views are checked is slightly different. * Using `descendants: true` to find the nested node outlet in order to handle a slight difference in how indirect content children are matched.
crisbeto
force-pushed
the
tree-ivy-refactor
branch
from
March 16, 2019 15:27
e651262
to
1ca22ba
Compare
mmalerba
pushed a commit
that referenced
this pull request
Mar 18, 2019
Equivalent of #15503 for the Ivy branch. Reworks the `MatTree` and `CdkTree` components to account for some of the changes in Ivy. This includes: * Changing the padding directive to account for a different time at which static inputs are initialized. * Changing the toggle directive to account for inheritance of host listeners working differently. * Switching to `Default` change detection, because the way embedded views are checked is slightly different. * Using `descendants: true` to find the nested node outlet in order to handle a slight difference in how indirect content children are matched.
mmalerba
pushed a commit
that referenced
this pull request
Mar 18, 2019
Reworks the `MatTree` and `CdkTree` components to account for some of the changes in Ivy. This includes: * Changing the padding directive to account for a different time at which static inputs are initialized. * Changing the toggle directive to account for inheritance of host listeners working differently. * Switching to `Default` change detection, because the way embedded views are checked is slightly different. * Using `descendants: true` to find the nested node outlet in order to handle a slight difference in how indirect content children are matched.
mmalerba
pushed a commit
that referenced
this pull request
Mar 18, 2019
Reworks the `MatTree` and `CdkTree` components to account for some of the changes in Ivy. This includes: * Changing the padding directive to account for a different time at which static inputs are initialized. * Changing the toggle directive to account for inheritance of host listeners working differently. * Switching to `Default` change detection, because the way embedded views are checked is slightly different. * Using `descendants: true` to find the nested node outlet in order to handle a slight difference in how indirect content children are matched.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
PR author has agreed to Google's Contributor License Agreement
P2
The issue is important to a large percentage of users, with a workaround
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the
MatTree
andCdkTree
components to account for some of the changes in Ivy. This includes:Default
change detection, because the way embedded views are checked is slightly different.descendants: true
to find the nested node outlet in order to handle a slight difference in how indirect content children are matched.