Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/form-field): align fill, outline, and standard appearance on hover behavior with spec #15618

Closed

Conversation

NicholasCobbFromGoogle
Copy link

@NicholasCobbFromGoogle NicholasCobbFromGoogle commented Mar 26, 2019

For mat-form-field elements being hovered (for fill, standard and outline appearances), the underline does not match that of the Google Material Spec. This PR should resolve that issue.

See Github Issue: #15583

Attached screenshots demonstrate the old behavior versus the new behavior on hovering (the cursor is not visible, but hovering is occurring):
Filled Now:
filled_after
Filled Before:
filled_before

Outline Now:
outline_after
Outline Before:
outline_before

Standard Now:
standard_after
Standard Before:
standard_before

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 26, 2019
@mmalerba mmalerba added the G This is is related to a Google internal issue label Mar 26, 2019
@jelbourn
Copy link
Member

jelbourn commented Apr 1, 2019

@mmalerba could you take a look?

@jelbourn
Copy link
Member

jelbourn commented Apr 1, 2019

We should double check that this is still compliant with https://material.io/design/components/text-fields.html

@mmalerba
Copy link
Contributor

The background color for the filled version looks quite dark in the focused state. Is that intentional, or accidental result of having background on both .mat-form-field-flex and .mat-form-field-flex::before and having the two blend together? Also the background color seems wrong in dark mode: https://mmalerba-demo4.firebaseapp.com/input

@NicholasCobbFromGoogle
Copy link
Author

Regarding the focused state, I made the fill colors based on the coloring of the fill inputs in the MDC Wiz Sandbox that Sterling White sent over email a bit ago: a background color approximately equal to our mat-gray-50 and black overlay of opacity 0 (still), 0.04 (hover), 0.12 (focused). However, after looking at his response on the email again, the color values seem to not match the colors in the Sandbox. The Sandbox did not appear to have dark mode equivalents, so I used the dark mode palette equivalents of the colors I picked for the light mode.

Since this scheme is incorrect, I have reverted to the color scheme to that used on the previous push.

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 3, 2019
@jelbourn jelbourn removed the action: merge The PR is ready for merge by the caretaker label May 13, 2019
@Splaktar Splaktar added the material spec Issue related to the Material Design spec https://material.io/design/ label Jan 6, 2020
@Splaktar Splaktar changed the title Resolves mat-form-fields not matching Material color specs for hovering feat(material/form-field): align fill, outline, and standard appearance on hover behavior with spec Jan 6, 2020
@Splaktar Splaktar changed the title feat(material/form-field): align fill, outline, and standard appearance on hover behavior with spec fix(material/form-field): align fill, outline, and standard appearance on hover behavior with spec Jan 6, 2020
@Splaktar
Copy link
Member

Can you please rebase this PR?

@jelbourn
Copy link
Member

@Splaktar at this point I don't see us merging changes like this for form-field since we're replacing it with the MDC-based version.

@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@annieyw
Copy link
Contributor

annieyw commented Mar 15, 2021

Closing because we are working on new MDC based components as mentioned above.

@annieyw annieyw closed this Mar 15, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue material spec Issue related to the Material Design spec https://material.io/design/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants