Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove staticQueryRule #16713

Merged
merged 1 commit into from Aug 8, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 8, 2019

Initially we added the rule to enforce that we always set the static flag on queries while it was still optional. Now we can remove it since the static flag is required.

Initially we added the rule to enforce that we always set the `static` flag on queries while it was still optional. Now we can remove it since the `static` flag is required.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe labels Aug 8, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 8, 2019
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 8, 2019
@jelbourn jelbourn merged commit 8ced0e7 into angular:master Aug 8, 2019
mmalerba pushed a commit that referenced this pull request Aug 14, 2019
Initially we added the rule to enforce that we always set the `static` flag on queries while it was still optional. Now we can remove it since the `static` flag is required.

(cherry picked from commit 8ced0e7)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants