fix(dialog): don't move focus if it was moved during close animation #17300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
17296/dialog-focus-restore
branch
2 times, most recently
from
81aa654
to
49c4979
Compare
Currently we restore focus to the previously-focused element once the dialog's exit animation has completed, however this can override any focus management the consumer might have done while the animation was running. These changes add extra check so that we only move focus if it was inside the dialog at the end of the animation. Fixes angular#17296.
crisbeto
force-pushed
the
17296/dialog-focus-restore
branch
from
49c4979
to
de4517d
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 7, 2019
…uring close animation Along the same lines as angular#17300. Restores focus only if focus is inside the dialog at the time the exit animation has finished. This avoids overriding focus that was moved while the dialog is animating away.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 7, 2019
… close animation Along the same lines as angular#17300. Restores focus only if focus is inside the dialog at the time the exit animation has finished. This avoids overriding focus that was moved while the dialog is animating away.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 15, 2019
…ation Currently we restore focus to the previously-focused element once the bottom sheet's exit animation has completed, however this can override any focus management the consumer might have done while the animation was running. These changes add extra check so that we only move focus if it was inside the bottom sheet at the end of the animation. Along the same lines as angular#17300.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we restore focus to the previously-focused element once the dialog's exit animation has completed, however this can override any focus management the consumer might have done while the animation was running. These changes add extra check so that we only move focus if it was inside the dialog at the end of the animation.
Fixes #17296.