Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: generate changelog for google-maps package #17563

Merged
merged 1 commit into from
Nov 1, 2019
Merged

build: generate changelog for google-maps package #17563

merged 1 commit into from
Nov 1, 2019

Conversation

devversion
Copy link
Member

We previously disabled the changelog generation for the google-maps
package. Now that we released it, we should enable the changelog generation
for future changes.

@devversion
build: generate changelog for google-maps package
28573f8 
We previously disabled the changelog generation for the `google-maps`
package. Now that we released it, we should enable the changelog generation
for future changes.
@devversion devversion requested a review from a team as a code owner November 1, 2019 09:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 1, 2019
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 1, 2019
crisbeto
crisbeto approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 1, 2019
josephperrott
josephperrott approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelbourn
jelbourn approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit f554610 into angular:master Nov 1, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@devversion @jelbourn @crisbeto @josephperrott @googlebot