test: menu tests flaky due to missing animation flush #17935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to: 1255139 Two recently added tests for the menu/mdc-menu and the MDC-one from the initial commit seem to miss a `tick` to flush the open animation. Without the flush, the `FakeAsyncTestZone` will report a pending timer on test completion.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: 1255139. Should fix flakiness as observed in https://circleci.com/gh/angular/components/100888
Two recently added tests for the menu/mdc-menu and the MDC-one from the
initial commit seem to miss a
tickto flush the open animation. Withoutthe flush, the
FakeAsyncTestZonewill report a pending timer on test completion.