build: fix ts 3.7 breaking changes #18163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were the only ones I found when testing with the snapshot artifacts from angular/angular#33717. Both are cases of https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#local-and-imported-type-declarations-now-conflict.
filipesilva
requested review from
devversion,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
filipesilva
commented
Jan 13, 2020
| @@ -26,7 +26,6 @@ import { | |||
| } from '@angular/core'; | |||
| import {NgControl} from '@angular/forms'; | |||
| import { | |||
| FloatLabelType, | |||
There was a problem hiding this comment.
@devversion can you verify this is the correct one to remove? It seems to be deprecated:
/**
* Type for the available floatLabel values.
* @deprecated Use `FloatLabelType` from `@angular/material/form-field` instead.
* @breaking-change 11.0.0
*/
export type FloatLabelType = 'always' | 'never' | 'auto';
But the local declaration is different:
/** Type for the available floatLabel values. */
export type FloatLabelType = 'always' | 'auto';
|
duplicate of #18141 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the only ones I found when testing with the snapshot artifacts from angular/angular#33717.
Both are cases of https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#local-and-imported-type-declarations-now-conflict.