Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix ts 3.7 breaking changes #18163

Closed

Conversation

@filipesilva
Copy link
Member

filipesilva commented Jan 13, 2020

These were the only ones I found when testing with the snapshot artifacts from angular/angular#33717.

Both are cases of https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#local-and-imported-type-declarations-now-conflict.

These were the only ones I found when testing with the snapshot artifacts from angular/angular#33717.

Both are cases of https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#local-and-imported-type-declarations-now-conflict.
@@ -26,7 +26,6 @@ import {
} from '@angular/core';
import {NgControl} from '@angular/forms';
import {
FloatLabelType,

This comment has been minimized.

Copy link
@filipesilva

filipesilva Jan 13, 2020

Author Member

@devversion can you verify this is the correct one to remove? It seems to be deprecated:

/**
 * Type for the available floatLabel values.
 * @deprecated Use `FloatLabelType` from `@angular/material/form-field` instead.
 * @breaking-change 11.0.0
 */
export type FloatLabelType = 'always' | 'never' | 'auto';

But the local declaration is different:

/** Type for the available floatLabel values. */
export type FloatLabelType = 'always' | 'auto';
@andrius-pra

This comment has been minimized.

Copy link
Contributor

andrius-pra commented Jan 13, 2020

duplicate of #18141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.