Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datepicker): implement range selection model #18247

Merged
merged 1 commit into from Jan 23, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 21, 2020

Implements the date range selection model in the individual range inputs.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe labels Jan 21, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 21, 2020
@crisbeto crisbeto changed the title refactor: tweak date selection model signature and implement model in range input refactor(datepicker): implement range selection model Jan 22, 2020
@crisbeto
Copy link
Member Author

@mmalerba I've reworked it so that we don't have to change the selection model signature and to avoid some potentially-breaky changes in the datepicker input generic. Can you take another look?

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from 1 nit

Implements the date range selection model in the individual range inputs.
@crisbeto crisbeto merged commit fd99256 into angular:date-range Jan 23, 2020
crisbeto added a commit that referenced this pull request Jan 24, 2020
Implements the date range selection model in the individual range inputs.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jan 24, 2020
Implements the date range selection model in the individual range inputs.
crisbeto added a commit that referenced this pull request Jan 29, 2020
Implements the date range selection model in the individual range inputs.
crisbeto added a commit that referenced this pull request Feb 5, 2020
Implements the date range selection model in the individual range inputs.
crisbeto added a commit that referenced this pull request Feb 17, 2020
Implements the date range selection model in the individual range inputs.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Feb 17, 2020
Implements the date range selection model in the individual range inputs.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants