Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): don't call date filter function if date is out of bounds #18419

Merged
merged 1 commit into from Feb 20, 2020
Merged

fix(datepicker): don't call date filter function if date is out of bounds #18419

merged 1 commit into from Feb 20, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 6, 2020

Doesn't call the dateFilter function for date is before the minimum or after the maximum in the month view. We were already doing this for the rest of the views, but I added some tests so we have coverage for it.

Fixes #18411.

@crisbeto
fix(datepicker): don't call date filter function if date is out of bo…
68ea6c8 
…unds

Doesn't call the `dateFilter` function for date is before the minimum or after the maximum in the month view. We were already doing this for the rest of the views, but I added some tests so we have coverage for it.

Fixes angular#18411.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Feb 6, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 6, 2020
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 6, 2020
@andrewseguin andrewseguin merged commit 5e34de2 into angular:master Feb 20, 2020
andrewseguin pushed a commit that referenced this pull request Feb 20, 2020
@crisbeto @andrewseguin
fix(datepicker): don't call date filter function if date is out of bo…
d2c952b 
…unds (#18419)

Doesn't call the `dateFilter` function for date is before the minimum or after the maximum in the month view. We were already doing this for the rest of the views, but I added some tests so we have coverage for it.

Fixes #18411.

(cherry picked from commit 5e34de2)
@snyk-bot snyk-bot mentioned this pull request Mar 11, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

matDatepickerFilter calls filter function even if the date is not withing min and max inputs
4 participants
@crisbeto @mmalerba @googlebot @andrewseguin