feat(datepicker): polish up date range selector #18531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes a bunch of changes to polish up the behavior of the date range picker. - Makes the range selection logic a bit smarter about when to pick start/end so that it's more intuitive. - Fixes hovering over disabled cells triggering the range selection styles. - Fixes a "changed after checked" error when selecting a range using the keyboard. - Implements validation that the start isn't after the end, and that the end isn't before the start. - Adds the missing ARIA attributes. - Fixes being able to select the placeholders of a disabled range input. - Adds the ability to disable the entire range input. - Fixes the inputs not greying out their values when they're disabled. - Makes the range input a bit smarter about which input to focus on click.
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
approved these changes
Feb 20, 2020
| }, | ||
| providers: [ | ||
| {provide: NG_VALUE_ACCESSOR, useExisting: MatStartDate, multi: true}, | ||
| {provide: NG_VALIDATORS, useExisting: MatStartDate, multi: true} | ||
| ] | ||
| }) | ||
| export class MatStartDate<D> extends _MatDateRangeInputBase<D> implements CanUpdateErrorState { | ||
| // TODO(crisbeto): start-range-specific validators should go here. | ||
| protected _validator = Validators.compose(super._getValidators()); | ||
| /** Validator that checks whether the start date isn't after the end date. */ |
There was a problem hiding this comment.
wording nit: whether --> that
| }, | ||
| providers: [ | ||
| {provide: NG_VALUE_ACCESSOR, useExisting: MatEndDate, multi: true}, | ||
| {provide: NG_VALIDATORS, useExisting: MatEndDate, multi: true} | ||
| ] | ||
| }) | ||
| export class MatEndDate<D> extends _MatDateRangeInputBase<D> implements CanUpdateErrorState { | ||
| // TODO(crisbeto): end-range-specific validators should go here. | ||
| protected _validator = Validators.compose(super._getValidators()); | ||
| /** Validator that checks whether the end date isn't before the start date. */ |
mmalerba
added
pr: lgtm
action: merge
|
ops, looks like this one got in before I had a chance to address the nits. I'll just push it directly to the |
crisbeto
added a commit
that referenced
this pull request
Feb 26, 2020
Makes a bunch of changes to polish up the behavior of the date range picker. - Makes the range selection logic a bit smarter about when to pick start/end so that it's more intuitive. - Fixes hovering over disabled cells triggering the range selection styles. - Fixes a "changed after checked" error when selecting a range using the keyboard. - Implements validation that the start isn't after the end, and that the end isn't before the start. - Adds the missing ARIA attributes. - Fixes being able to select the placeholders of a disabled range input. - Adds the ability to disable the entire range input. - Fixes the inputs not greying out their values when they're disabled. - Makes the range input a bit smarter about which input to focus on click.
crisbeto
added a commit
that referenced
this pull request
Mar 12, 2020
Makes a bunch of changes to polish up the behavior of the date range picker. - Makes the range selection logic a bit smarter about when to pick start/end so that it's more intuitive. - Fixes hovering over disabled cells triggering the range selection styles. - Fixes a "changed after checked" error when selecting a range using the keyboard. - Implements validation that the start isn't after the end, and that the end isn't before the start. - Adds the missing ARIA attributes. - Fixes being able to select the placeholders of a disabled range input. - Adds the ability to disable the entire range input. - Fixes the inputs not greying out their values when they're disabled. - Makes the range input a bit smarter about which input to focus on click.
crisbeto
added a commit
that referenced
this pull request
Mar 17, 2020
Makes a bunch of changes to polish up the behavior of the date range picker. - Makes the range selection logic a bit smarter about when to pick start/end so that it's more intuitive. - Fixes hovering over disabled cells triggering the range selection styles. - Fixes a "changed after checked" error when selecting a range using the keyboard. - Implements validation that the start isn't after the end, and that the end isn't before the start. - Adds the missing ARIA attributes. - Fixes being able to select the placeholders of a disabled range input. - Adds the ability to disable the entire range input. - Fixes the inputs not greying out their values when they're disabled. - Makes the range input a bit smarter about which input to focus on click.
crisbeto
added a commit
that referenced
this pull request
Mar 21, 2020
Makes a bunch of changes to polish up the behavior of the date range picker. - Makes the range selection logic a bit smarter about when to pick start/end so that it's more intuitive. - Fixes hovering over disabled cells triggering the range selection styles. - Fixes a "changed after checked" error when selecting a range using the keyboard. - Implements validation that the start isn't after the end, and that the end isn't before the start. - Adds the missing ARIA attributes. - Fixes being able to select the placeholders of a disabled range input. - Adds the ability to disable the entire range input. - Fixes the inputs not greying out their values when they're disabled. - Makes the range input a bit smarter about which input to focus on click.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a bunch of changes to polish up the behavior of the date range picker.
With these changes the date range picker should be mostly feature-complete.