Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-*): rename sass mixins to mat-mdc-* #18615

Merged
merged 1 commit into from
Mar 9, 2020
Merged

fix(material-experimental/mdc-*): rename sass mixins to mat-mdc-* #18615

merged 1 commit into from
Mar 9, 2020

Conversation

mmalerba
Copy link
Contributor

CARETAKER NOTE: These changes will need to happen in g3 too. This can be accomplished with the following 2 regex find/replaces:

  • mat-(.*)-(theme|typography)-mdc => mat-mdc-$1-$2
  • angular-material-(theme|typography)-mdc => angular-material-mdc-$1

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release labels Feb 25, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 25, 2020
crisbeto
crisbeto approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 26, 2020
@mmalerba mmalerba merged commit b91e88f into angular:master Mar 9, 2020
@mmalerba mmalerba deleted the mdc-naming branch March 9, 2020 22:44
mmalerba added a commit that referenced this pull request Mar 10, 2020
@mmalerba
fix(material-experimental/mdc-*): rename sass mixins to mat-md… (#18615)
694386a
timsawyer pushed a commit to timsawyer/components that referenced this pull request Mar 10, 2020
@mmalerba @timsawyer
fix(material-experimental/mdc-*): rename sass mixins to mat-md… (angu…
8cd8429 
…lar#18615)
This was referenced Mar 13, 2020
Merged
Merged
This was referenced Mar 28, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 8, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmalerba @crisbeto @devversion @jelbourn @googlebot