Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): cancel current range selection when pressing escape #18630

Merged
merged 1 commit into from Feb 27, 2020
Merged

fix(datepicker): cancel current range selection when pressing escape #18630

merged 1 commit into from Feb 27, 2020

Conversation

crisbeto
Copy link
Member

Adds some extra logic so that the user can abort the current range selection if they press the escape key.

@crisbeto
fix(datepicker): cancel current range selection when pressing escape
7873c95 
Adds some extra logic so that the user can abort the current range selection if they press the escape key.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe labels Feb 26, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 26, 2020
mmalerba
mmalerba approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 27, 2020
@crisbeto crisbeto merged commit 0b2abce into angular:date-range Feb 27, 2020
crisbeto added a commit that referenced this pull request Mar 12, 2020
@crisbeto
fix(datepicker): cancel current range selection when pressing escape (#…
39fd72b 
…18630)

Adds some extra logic so that the user can abort the current range selection if they press the escape key.
crisbeto added a commit that referenced this pull request Mar 17, 2020
@crisbeto
fix(datepicker): cancel current range selection when pressing escape (#…
bb675f4 
…18630)

Adds some extra logic so that the user can abort the current range selection if they press the escape key.
crisbeto added a commit that referenced this pull request Mar 21, 2020
@crisbeto
fix(datepicker): cancel current range selection when pressing escape (#…
18eccf4 
…18630)

Adds some extra logic so that the user can abort the current range selection if they press the escape key.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @mmalerba @googlebot