-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datepicker): implement comparison and overlap ranges #18753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like the yellow circles, it's very confusing to look at and try to understand. Instead of a straightforward mental mapping like:
- blue = only selected range occupies this cell
- yellow = only comparison range occupies this cell
- green = both ranges occupy this cell
We get:
- blue = only selected range occupies this cell
- yellow = ¯\(ツ)/¯
- green = both ranges occupy this cell
I propose just making the dark yellow circle a dark green circle, and if people really want their users to be confused they can always override it
49cf372
to
cb5639b
Compare
I've reworked it based on the feedback @mmalerba |
|
Did some hacking in chrome devtools and this seemed to fix the first issue for LTR:
Would still need to be updated for RTL (which is currently broken with and without these adjustments). It might just be worth revisiting this whole approach though, as it seems very complicated and brittle |
117afc7
to
ff6461e
Compare
Adds the ability to render a comparison range in the date range picker. When the comparison overlaps with the primary range, the overlapping dates are shown in a separate "overlap" range.
ff6461e
to
673e452
Compare
Adds the ability to render a comparison range in the date range picker. When the comparison overlaps with the primary range, the overlapping dates are shown in a separate "overlap" range.
Adds the ability to render a comparison range in the date range picker. When the comparison overlaps with the primary range, the overlapping dates are shown in a separate "overlap" range.
Adds the ability to render a comparison range in the date range picker. When the comparison overlaps with the primary range, the overlapping dates are shown in a separate "overlap" range.
Adds the ability to render a comparison range in the date range picker. When the comparison overlaps with the primary range, the overlapping dates are shown in a separate "overlap" range.
Adds the ability to render a comparison range in the date range picker. When the comparison overlaps with the primary range, the overlapping dates are shown in a separate "overlap" range.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds the ability to render a comparison range in the date range picker. When the comparison overlaps with the primary range, the overlapping dates are shown in a separate "overlap" range.
Some examples for reference: