Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(radio): clicks not landing correctly in some cases on Chrome (#18357)" #18820

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Mar 13, 2020

Had problems internally when users wanted to focus an <input> inside of a radio option after that option is selected. Please commit the changes to a new PR so we can continue working on it

This reverts commit fe29835.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2020
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 13, 2020
@andrewseguin andrewseguin merged commit b5b3c8a into angular:master Mar 13, 2020
andrewseguin added a commit that referenced this pull request Mar 13, 2020
…ome (#18357)" (#18820)

This reverts commit fe29835.

(cherry picked from commit b5b3c8a)
@andrewseguin
Copy link
Contributor Author

Here's a stripped down version of what I found users doing https://stackblitz.com/edit/angular-k9v2jr?file=src/app/radio-overview-example.ts

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants