Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(form-field): Use Form Validation in custom control example #18844

Merged
merged 1 commit into from Mar 16, 2020
Merged

docs(form-field): Use Form Validation in custom control example #18844

merged 1 commit into from Mar 16, 2020

Conversation

tobiasschweizer
Copy link
Contributor

closes #18817

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 16, 2020
@tobiasschweizer tobiasschweizer mentioned this pull request Mar 16, 2020
Closed
mmalerba
mmalerba approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fix!

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 16, 2020
@mmalerba mmalerba changed the title Custom-Form-Field: Use Form Validation docs(form-field): Use Form Validation in custom control example Mar 16, 2020
@mmalerba mmalerba merged commit 511f076 into angular:master Mar 16, 2020
@tobiasschweizer tobiasschweizer deleted the tobiasschweizer/18817-validation branch March 17, 2020 08:07
@tobiasschweizer tobiasschweizer mentioned this pull request Mar 17, 2020
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(Guide: Creating a custom form field control): Missing Validators in FormGroup
3 participants
@tobiasschweizer @mmalerba @googlebot