Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor: change isDateInstance return type to is D" #18897

Merged
merged 1 commit into from Mar 23, 2020

Conversation

@mmalerba
Copy link
Contributor

mmalerba commented Mar 23, 2020

Reverts #18786

@mmalerba mmalerba requested a review from jelbourn as a code owner Mar 23, 2020
@googlebot googlebot added the cla: yes label Mar 23, 2020
@mmalerba

This comment has been minimized.

Copy link
Contributor Author

mmalerba commented Mar 23, 2020

@DevTrong sorry I realized that this is actually a breaking API change - we will have to wait until a major release to make this change, and we'll need schematics to migrate users. Please feel free to open a new PR.

Copy link
Member

crisbeto left a comment

LGTM

@mmalerba mmalerba merged commit 16e2cf0 into master Mar 23, 2020
13 of 14 checks passed
13 of 14 checks passed
ci/angular: merge status Missing required labels: target: *
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility_snapshot Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@mmalerba mmalerba deleted the revert-18786-refactor-isdateinstance branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.