Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drag-drop): allow preview z-index to be changed #18914

Merged
merged 1 commit into from Mar 31, 2020
Merged

fix(drag-drop): allow preview z-index to be changed #18914

merged 1 commit into from Mar 31, 2020

Conversation

crisbeto
Copy link
Member

The CDK drag preview has a z-index that works with the CDK overlay, but might be too low for other libraries. These changes add an option that allows consumers to override it.

Fixes #18902.

@crisbeto
fix(drag-drop): allow preview z-index to be changed
429c13d 
The CDK drag preview has a `z-index` that works with the CDK overlay, but might be too low for other libraries. These changes add an option that allows consumers to override it.

Fixes angular#18902.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 25, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 25, 2020
jelbourn
jelbourn approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 25, 2020
@jelbourn jelbourn merged commit 4e02a95 into angular:master Mar 31, 2020
jelbourn pushed a commit that referenced this pull request Apr 6, 2020
@crisbeto @jelbourn
fix(drag-drop): allow preview z-index to be changed (#18914)
5c88e67 
The CDK drag preview has a `z-index` that works with the CDK overlay, but might be too low for other libraries. These changes add an option that allows consumers to override it.

Fixes #18902.

(cherry picked from commit 4e02a95)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fr(Drag-Drop): Setting z-index
3 participants
@crisbeto @jelbourn @googlebot