-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(interactivity-checker): improve robustness of isTabbable #1950
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import {Component} from '@angular/core'; | ||
import {MdPlatform} from '@angular/material'; | ||
|
||
@Component({ | ||
template: ` | ||
<p>Is Android: {{ platform.ANDROID }}</p> | ||
<p>Is iOS: {{ platform.IOS }}</p> | ||
<p>Is Firefox: {{ platform.FIREFOX }}</p> | ||
<p>Is Blink: {{ platform.BLINK }}</p> | ||
<p>Is Webkit: {{ platform.WEBKIT }}</p> | ||
<p>Is Trident: {{ platform.TRIDENT }}</p> | ||
<p>Is Edge: {{ platform.EDGE }}</p> | ||
|
||
` | ||
}) | ||
export class PlatformDemo { | ||
|
||
constructor(public platform: MdPlatform) {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove extra blank lines There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think that's a big deal - Is there any specific convention in the Google JavaScript conventions? - Going to change it though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think there's any official convention for it, I just like to keep it consistent throughout the project. Most other files I've looked at seem to not leave space here |
||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra blank line