fix(drag-drop): allow handle to be set on drag element if there is a different drag root #19559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
|
@crisbeto passes presubmit, just needs rebase |
crisbeto
force-pushed
the
19555/drag-drop-self-handle
branch
from
5b7d03e
to
f9c3fb3
Compare
|
Rebased. |
|
@crisbeto after rebase it looks like integration_tests have a failure |
crisbeto
force-pushed
the
19555/drag-drop-self-handle
branch
from
f9c3fb3
to
7b5ca5f
Compare
…different drag root Currently we only allow the drag handle to be a descendant of the drag element, but this can be inconvenient if the drag root is moved further up the DOM using `cdkDragRootElement`. These changes allow for a handle to be set on the drag element itself, if it has an alternate drag root. Fixes angular#19555.
crisbeto
force-pushed
the
19555/drag-drop-self-handle
branch
from
7b5ca5f
to
bfa8941
Compare
|
Fixed the size failure. |
devversion
approved these changes
Jul 2, 2020
mmalerba
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only allow the drag handle to be a descendant of the drag element, but this can be inconvenient if the drag root is moved further up the DOM using
cdkDragRootElement. These changes allow for a handle to be set on the drag element itself, if it has an alternate drag root.Fixes #19555.