Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(material-experimental/mdc-button): add README #19888

Merged
merged 3 commits into from Jul 8, 2020
Merged

docs(material-experimental/mdc-button): add README #19888

merged 3 commits into from Jul 8, 2020

Conversation

andrewseguin
Copy link
Contributor

No description provided.

@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Jul 7, 2020
crisbeto
crisbeto approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 7, 2020
devversion
devversion approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two super minor nits

src/material-experimental/mdc-button/README.md Outdated Show resolved Hide resolved
src/material-experimental/mdc-button/README.md Outdated Show resolved Hide resolved
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 7, 2020
@mmalerba mmalerba merged commit 6f83ed2 into angular:master Jul 8, 2020
mmalerba pushed a commit that referenced this pull request Jul 8, 2020
@andrewseguin @mmalerba
docs(material-experimental/mdc-button): add README (#19888)
b1584d9 
* docs(material-experimental/mdc-button): add README

* rename FAB, include new theming

* fix theming
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrewseguin @crisbeto @devversion @googlebot @mmalerba