Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (a11y): add parent node check when removing existing aria describe #19951

Merged
merged 4 commits into from
Jul 28, 2020
Merged

fix (a11y): add parent node check when removing existing aria describe #19951

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79289b8
added a null guard
Jul 12, 2020
26b16cf
remove !
Jul 12, 2020
cd38374
fix (a11y): add parent node check when removing existing aria describe
Jul 12, 2020
e3014e4
Merge branch 'add-guard' of https://github.com/shawn-avrio/components…
Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cdk/a11y/aria-describer/aria-describer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ export class AriaDescriber implements OnDestroy {
// already a container on the page, but we don't have a reference to it. Clear the
// old container so we don't get duplicates. Doing this, instead of emptying the previous
// container, should be slightly faster.
if (preExistingContainer) {
preExistingContainer.parentNode!.removeChild(preExistingContainer);
if (preExistingContainer && preExistingContainer.parentNode) {
preExistingContainer.parentNode.removeChild(preExistingContainer);
Comment on lines +162 to +163
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this just be

preExistingContainer?.parentNode?.removeChild(preExistingContainer);

}

messagesContainer = this._document.createElement('div');
Expand Down