Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugoer/material table #20149

Merged
merged 10 commits into from
Aug 21, 2020
Merged

Conversation

Hugoer
Copy link
Contributor

@Hugoer Hugoer commented Jul 31, 2020

Correctly sort the data in a column when it contains string data and numeric values. If this occurs, numeric values are converted to text

Sort correctly when column information has string and numeric values

Fixes angular#20140
Sort correctly when column information has string and numeric values

Fixes angular#20140
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 31, 2020
Sort correctly when column information has string and numeric values
Sort correctly when column information has string and numeric values
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR also missing a proper title and description, and the commit titles should be a bit more descriptive.

src/material/table/table-data-source.ts Outdated Show resolved Hide resolved
src/material/table/table-data-source.ts Outdated Show resolved Hide resolved
src/material/table/table-data-source.ts Outdated Show resolved Hide resolved
Correctly sort the data in a column when it contains string data and numeric values. If this occurs, numeric values are converted to text
Correctly sort the data in a column when it contains string data and numeric values. If this occurs, numeric values are converted to text
Correctly sort the data in a column when it contains string data and numeric values. If this occurs, numeric values are converted to text
@Hugoer
Copy link
Contributor Author

Hugoer commented Aug 5, 2020

The PR also missing a proper title and description, and the commit titles should be a bit more descriptive.

Please, tell me if it is needed more information and i would add it. Sorry about number of commits, i did it from mobile because of i am not at home for some days.

Correctly sort the data in a column when it contains string data and numeric values. If this occurs, numeric values are converted to text
@crisbeto
Copy link
Member

crisbeto commented Aug 7, 2020

The commit title still seems pretty generic and won't tell people much when it makes it to the changelog. Maybe something along the lines of "fix(table): correctly sort columns with mixed data types"?

@Hugoer
Copy link
Contributor Author

Hugoer commented Aug 17, 2020

The commit title still seems pretty generic and won't tell people much when it makes it to the changelog. Maybe something along the lines of "fix(table): correctly sort columns with mixed data types"?

Done! i did a git commit amend, it is right?

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 17, 2020
@crisbeto
Copy link
Member

Commit message fixup: use message from last commit when squashing (fix(table): correctly sort columns with mixed data types).

@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 21, 2020
@wagnermaciel wagnermaciel merged commit 21f2df3 into angular:master Aug 21, 2020
@Hugoer Hugoer deleted the hugoer/material-table branch September 14, 2020 08:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants