fix(slider): don't emit change events on mousedown #20240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
|
Caretaker note: this has the potential to break people's tests, as evidenced by the changes I had to make to our own tests. We should see how break-ey this is before we invest a lot of time trying to get it synced in. |
Currently when the user presses down somewhere on the slider we emit a `change` event, as well as when they release. While we don't emit the same value twice, the timing seems to be unexpected by consumers, because one happens at the begging of the sequence and another one at the end. These changes make it so that we only emit the change event once the user has released the slider. Fixes angular#14363.
crisbeto
force-pushed
the
14363/slider-change-event-mousedown
branch
from
3651231
to
0b3020e
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Aug 14, 2020
Currently when the user presses down somewhere on the slider we emit a `change` event, as well as when they release. While we don't emit the same value twice, the timing seems to be unexpected by consumers, because one happens at the begging of the sequence and another one at the end. These changes make it so that we only emit the change event once the user has released the slider. Fixes #14363. (cherry picked from commit ce72369)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the user presses down somewhere on the slider we emit a
changeevent, as well as when they release. While we don't emit the same value twice, the timing seems to be unexpected by consumers, because one happens at the begging of the sequence and another one at the end.These changes make it so that we only emit the change event once the user has released the slider.
Fixes #14363.
Note: I'm setting it to P2, because it's a long standing issue that people keep bumping into.