Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-core): set up strong focus indication for MDC-based option #20354

Merged
merged 1 commit into from
Aug 20, 2020
Merged

fix(material-experimental/mdc-core): set up strong focus indication for MDC-based option #20354

merged 1 commit into from
Aug 20, 2020

Conversation

crisbeto
Copy link
Member

The MDC-based mat-option had the proper strong focus indicator class, but the styles weren't implemented.

@crisbeto
fix(material-experimental/mdc-core): set up strong focus indication f…
eef67a5 
…or MDC-based option

The MDC-based `mat-option` had the proper strong focus indicator class, but the styles weren't implemented.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Aug 18, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 18, 2020
mmalerba
mmalerba approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 18, 2020
@wagnermaciel wagnermaciel merged commit 9a4adb7 into angular:master Aug 20, 2020
wagnermaciel pushed a commit that referenced this pull request Aug 20, 2020
@crisbeto @wagnermaciel
fix(material-experimental/mdc-core): set up strong focus indication f…
1768036 
…or MDC-based option (#20354)

The MDC-based `mat-option` had the proper strong focus indicator class, but the styles weren't implemented.

(cherry picked from commit 9a4adb7)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @mmalerba @googlebot @wagnermaciel