New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(material/sidenav): undeprecate constructor signature #20589
Conversation
@crisbeto Please resolve this merge conflict |
8481ea7
to
a2fd07d
Compare
Rebased. |
a2fd07d
to
37f69c5
Compare
Apps using |
I was under the impression that we require sidenavs to be inside a container. If that's not the case we can un-deprecate the signature. Can you weigh in @mmalerba? |
@crisbeto this came up because someone is actually doing it- we found an instance where |
I was asking, because I had the impression that we needed a sidenav inside a container, but if that's not the case and we want to support it, keeping the parameter optional won't be a big deal. |
I don't feel strongly either way; it certainly was never intended to work, but it's probably not worth the effort to fix it |
Okay, in that case I'll revert the changes and turn this PR into a merge-safe one that un-deprecates the old signature. |
0e9a0e0
to
5ab0bd1
Compare
Removes the deprecation labels from a constructor parameter since it's tricky to sync into g3 and is easy to maintain on our end.
5ab0bd1
to
862a390
Compare
Removes the deprecation labels from a constructor parameter since it's tricky to sync into g3 and is easy to maintain on our end. (cherry picked from commit 993767f)
…r#20589) Removes the deprecation labels from a constructor parameter since it's tricky to sync into g3 and is easy to maintain on our end.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removes the deprecation labels from a constructor parameter since it's tricky to
sync into g3 and is easy to maintain on our end.