Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cdk/table): document fixedLayout and recycleRows #21926

Merged
merged 1 commit into from Aug 19, 2021
Merged

docs(cdk/table): document fixedLayout and recycleRows #21926

merged 1 commit into from Aug 19, 2021

Conversation

MichaelJamesParsons
Copy link
Collaborator

Documents fixedLayout and recycleRows directives for the CdkTable.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 16, 2021
@MichaelJamesParsons MichaelJamesParsons mentioned this pull request Feb 16, 2021
Merged
jelbourn
jelbourn reviewed Feb 16, 2021
View reviewed changes
src/cdk/table/table.md Outdated
@@ -135,6 +135,14 @@ updates. This can be based on _anything_: websocket connections, user interactio
time-based intervals, etc. Most commonly, updates will be triggered by user interactions like
sorting and pagination.

##### `fixedLayout`
Enabling this option will enforce uniform column widths and optimize the rendering of sticky
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention that this option only applies to native <table> elements and not to the flexbox-based <cdk-table>.

Would it also be possible to expand on this explanation a bit with details on why this is valuable for optimizing sticky elements?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/cdk/table/table.md Outdated Show resolved Hide resolved
crisbeto
crisbeto approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-cla
Copy link

google-cla bot commented Aug 10, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Aug 10, 2021
@google-cla google-cla bot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Aug 10, 2021
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Aug 18, 2021
@amysorto amysorto merged commit 4a32707 into angular:master Aug 19, 2021
amysorto pushed a commit that referenced this pull request Aug 19, 2021
@MichaelJamesParsons @amysorto
docs(cdk/table): document fixedLayout and recycleRows (#21926)
f980bde 
(cherry picked from commit 4a32707)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MichaelJamesParsons @jelbourn @crisbeto @mmalerba @amysorto