refactor(multiple): switch to non-deprecated MDC list styles #22504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
|
Caretaker note: in the process of migrating the styles for |
crisbeto
force-pushed
the
mdc-list-evolution
branch
3 times, most recently
from
9fbe441
to
8fb3c36
Compare
devversion
approved these changes
Apr 18, 2021
|
@crisbeto is this available in canary now? |
|
It's not available in canary yet. It's waiting for material-components/material-components-web#7021. |
crisbeto
force-pushed
the
mdc-list-evolution
branch
from
8fb3c36
to
7c612b7
Compare
|
Unblocking this since the necessary changes are in the canary branch now. |
crisbeto
force-pushed
the
mdc-list-evolution
branch
from
7c612b7
to
e957449
Compare
crisbeto
added
action: merge
crisbeto
force-pushed
the
mdc-list-evolution
branch
3 times, most recently
from
97faee6
to
89dc94a
Compare
|
FYI, I had to lock us to a specific canary version, because having the caret in the version caused yarn to install an older canary version of MDC for some reason. I've locked us to the current latest canary. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 4, 2021
Our MDC version requirement currently uses a caret with the intention of allowing any version after the specified canary. This isn't actually how npm works and it can end up installing an earlier version. The version isn't technically valid semver, causing the package manager to sort the versions alphabetically and to pick the last one. This behavior threw me off when rebasing angular#22504 yesterday, because it ended up installing a version that was too old. These changes lock us to a specific version.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 7, 2021
Our MDC version requirement currently uses a caret with the intention of allowing any version after the specified canary. This isn't actually how npm works and it can end up installing an earlier version. The version isn't technically valid semver, causing the package manager to sort the versions alphabetically and to pick the last one. This behavior threw me off when rebasing angular#22504 yesterday, because it ended up installing a version that was too old. These changes lock us to a specific version.
andrewseguin
pushed a commit
that referenced
this pull request
Jun 8, 2021
Our MDC version requirement currently uses a caret with the intention of allowing any version after the specified canary. This isn't actually how npm works and it can end up installing an earlier version. The version isn't technically valid semver, causing the package manager to sort the versions alphabetically and to pick the last one. This behavior threw me off when rebasing #22504 yesterday, because it ended up installing a version that was too old. These changes lock us to a specific version.
crisbeto
force-pushed
the
mdc-list-evolution
branch
from
89dc94a
to
abf8f52
Compare
mmalerba
reviewed
Jun 21, 2021
crisbeto
force-pushed
the
mdc-list-evolution
branch
2 times, most recently
from
803ef9a
to
24a3d6c
Compare
Switches the components in `mdc-autocomplete`, `mdc-core`, `mdc-menu` and `mdc-select` to the non-deprecated MDC list styles.
crisbeto
force-pushed
the
mdc-list-evolution
branch
from
24a3d6c
to
8389383
Compare
mmalerba
pushed a commit
that referenced
this pull request
Jun 22, 2021
Switches the components in `mdc-autocomplete`, `mdc-core`, `mdc-menu` and `mdc-select` to the non-deprecated MDC list styles. (cherry picked from commit f960a7a)
mmalerba
pushed a commit
that referenced
this pull request
Jun 22, 2021
Switches the components in `mdc-autocomplete`, `mdc-core`, `mdc-menu` and `mdc-select` to the non-deprecated MDC list styles. (cherry picked from commit f960a7a)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the components in
mdc-autocomplete,mdc-core,mdc-menuandmdc-selectto the non-deprecated MDC list styles.Note for reviewer: merging this is currently blocked, because it depends on one change that isn't in the latest canary version. Once the change is released, I'll bump the version and unblock merging. The code can still be reviewed.