Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-button): fix ripple size after MDC changes #23266

Merged
merged 1 commit into from Aug 6, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jul 28, 2021

Project import generated by Copybara.

CARETAKER NOTE: This should be merged once cl/386915262 is submitted

@google-cla
Copy link

google-cla bot commented Jul 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jul 28, 2021
@google-cla
Copy link

google-cla bot commented Jul 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mmalerba mmalerba changed the title Project import generated by Copybara. fix(material-experimental/mdc-button): fix ripple size after MDC changes Jul 28, 2021
@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement blocked This issue is blocked by some external factor, such as a prerequisite PR merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jul 28, 2021
@allan-chen
Copy link

This should be submittable now.

@andrewseguin
Copy link
Contributor

Thanks for the update Allan - will merge shortly

@andrewseguin andrewseguin removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Aug 6, 2021
@andrewseguin andrewseguin merged commit e57bae0 into master Aug 6, 2021
andrewseguin pushed a commit that referenced this pull request Aug 6, 2021
…ges (#23266)

PiperOrigin-RevId: 387458042

Co-authored-by: Angular Material Team <material@angular.io>
(cherry picked from commit e57bae0)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants