feat(google-maps): switch to non-deprecated typings #23350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
commented
Aug 11, 2021
| callback: Function) => { | ||
| callback(result, status); | ||
| const result: google.maps.DirectionsResult = {routes: []}; | ||
| const status = 'OK' as google.maps.DirectionsStatus; |
There was a problem hiding this comment.
I can't use the enum in tests, because we don't actually load the API.
crisbeto
force-pushed
the
22818/google-maps-deprecated-typings
branch
from
63e2ec7 to
7b0cd0f
Compare
crisbeto
force-pushed
the
22818/google-maps-deprecated-typings
branch
from
7b0cd0f to
e47ff9f
Compare
|
cc @jelbourn |
crisbeto
force-pushed
the
22818/google-maps-deprecated-typings
branch
from
e47ff9f to
06c5972
Compare
jelbourn
reviewed
Aug 28, 2021
crisbeto
force-pushed
the
22818/google-maps-deprecated-typings
branch
from
06c5972 to
2a6d926
Compare
|
The feedback has been addressed. |
|
Just realized that we should also add a breaking changes note to the commit |
mbehrlich
reviewed
Aug 30, 2021
mbehrlich
approved these changes
Aug 30, 2021
crisbeto
force-pushed
the
22818/google-maps-deprecated-typings
branch
from
2a6d926 to
6c341e9
Compare
crisbeto
force-pushed
the
22818/google-maps-deprecated-typings
branch
from
6c341e9 to
ca39616
Compare
Moves the `google-maps` package away from the deprecated typings. Fixes angular#22818.
crisbeto
force-pushed
the
22818/google-maps-deprecated-typings
branch
from
ca39616 to
16e6a88
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
google-mapspackage away from the deprecated typings.Fixes #22818.