fix(material/tabs): fix contentTabIndex input type #23413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
byanofsky
force-pushed
the
fix-tab-types
branch
2 times, most recently
from
7851e8b
to
9e1355c
Compare
MatTabGroup's property `contentTabIndex` specifies its type as `number | null`. However, the `ngAcceptInputType` is specified as `BooleanInput`. Fixes the input type to be `NumberInput` to align with property type.
byanofsky
force-pushed
the
fix-tab-types
branch
from
9e1355c
to
d1baf8d
Compare
crisbeto
added
action: merge
devversion
approved these changes
Aug 20, 2021
zarend
pushed a commit
that referenced
this pull request
Sep 7, 2021
MatTabGroup's property `contentTabIndex` specifies its type as `number | null`. However, the `ngAcceptInputType` is specified as `BooleanInput`. Fixes the input type to be `NumberInput` to align with property type. (cherry picked from commit 4414b04)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatTabGroup's property
contentTabIndexspecifies its type asnumber | null. However, thengAcceptInputTypeis specified asBooleanInput.Fixes the input type to be
NumberInputto align with property type.